adds ceiling and floor overflow/underflow tests#87
Open
raleigh-g-thompson wants to merge 1 commit intomainfrom
Open
adds ceiling and floor overflow/underflow tests#87raleigh-g-thompson wants to merge 1 commit intomainfrom
raleigh-g-thompson wants to merge 1 commit intomainfrom
Conversation
brynrhodes
requested changes
Oct 22, 2025
| <output>null</output> | ||
| </test> | ||
| <test name="CeilingIntegerGreaterThanMaxInteger" version="1.0"> | ||
| <expression>Ceiling(2147483648)</expression> |
Member
There was a problem hiding this comment.
Have you tested this expression? I think it might actually be invalid?
Contributor
Author
There was a problem hiding this comment.
Yes, SmileCDR returns this
{
"severity": "error",
"details": {
"text": "Bad format for Integer literal"
}
}
Contributor
Author
There was a problem hiding this comment.
Should this be marked as a semantic or runtime issue?
| <output>-2147483648</output> | ||
| </test> | ||
| <test name="CeilingIntegerLessThanMinInteger" version="1.0"> | ||
| <expression>Ceiling(-2147483649)</expression> |
Member
There was a problem hiding this comment.
Same here, seems like this would blow up in the parser?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #30